fix: avoid throwing exception in destructor #146
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When data compression is enabled,
CompressedOutput
will be created inClient::Impl::SendData
. If the socket is unfortunately broken during the execution ofSocketOutput::DoWrite
, astd::system_error
exception will be thrown. Next, the destructor ofCompressedOutput
will be called during stack unwinding, and thenFlush()
in~CompressedOutput
will callSocketOutput::DoWrite
again, eventually causing the program to terminate.