Add recv/send timeouts to socket #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello! We faced this problem in our project and this PR is the solution. Do you need any help to merge? |
Yes, I don’t have rights for merging |
|
@horoshenkiy I don't have rights either. I mean do you know anything I can help with? PR is 24 days old. Is the only way to wait for a contributor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working with the library, I found the following behavior: when my application is connecting to the clickhouse server, it may stick forever due to connection problems.
A connection to the server can be established, but nothing can be read from the socket because you try to connect to another running application in your system.
For resolving this problem I added receive and send timeouts to socket.