Skip to content

Receiving columns metadata #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Conversation

den818
Copy link
Contributor

@den818 den818 commented Oct 9, 2022

Columns metadata is sent if only it is a query like "INSERT INTO {TableName} VALUES" when values are sent as separate data. Such queries can be dispatched only by these functions:

    /// Intends for insert block of data into a table \p table_name.
    void Insert(const std::string& table_name, const Block& block);
    void Insert(const std::string& table_name, const std::string& query_id, const Block& block);

The parameter block has already formed in these functions at the time of the call. Analyzing columns' defaults for changing data seems useless. That's why I just skiped this data.

@Enmk Enmk merged commit c1bf280 into ClickHouse:master Oct 17, 2022
@den818 den818 deleted the COLUMN_DEFAULTS_METADATA branch October 17, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants