Skip to content

fix win compile error if enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix win compile error if enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS #226

wants to merge 2 commits into from

Conversation

1261385937
Copy link
Contributor

No description provided.

@1261385937 1261385937 mentioned this pull request Oct 16, 2022
Merged
xakod
xakod reviewed Oct 16, 2022
View reviewed changes
Enmk
Enmk suggested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide compiler error message with some background in PR description, RN it is not entirely clear why this change required.

@1261385937 1261385937 closed this Oct 17, 2022
@1261385937

This comment was marked as outdated.

Sign in to view
@1261385937 1261385937 reopened this Oct 17, 2022
@1261385937 1261385937 marked this pull request as draft October 21, 2022 12:20
@1261385937 1261385937 marked this pull request as ready for review October 21, 2022 12:21
@1261385937 1261385937 marked this pull request as draft October 21, 2022 12:21
@1261385937 1261385937 requested a review from Enmk October 21, 2022 13:35
@Enmk
Copy link
Contributor

Enmk commented Dec 10, 2022

@1261385937 Major question, why do you need to enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ?

@xakod
Copy link
Contributor

xakod commented Dec 10, 2022

@1261385937 Major question, why do you need to enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ?

Windows shared library requires import library. Cmake can build it by default without specificing export symbols with CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS

@1261385937
Copy link
Contributor Author

1261385937 commented Dec 11, 2022 •
edited
Loading

@1261385937 Major question, why do you need to enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ?

Or should add __declspec(dllexport) for class if want to export symbols

@1261385937
Copy link
Contributor Author

Windows static lib may be better.
I will close this draft.

@1261385937 1261385937 closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xakod xakod xakod left review comments

@Enmk Enmk Awaiting requested review from Enmk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1261385937 @Enmk @xakod