The use of local timezone in DateTime conversion is inconsistent with CLI client

[larry-cdn77]

DateTime parsing defaults to using client zone (time.Local)

clickhouse-go/lib/column/datetime64.go

Line 314 in 8d87c23

return getTimeWithDifferentLocation(tv, time.Local), nil

I believe this was introduced in 0704ee8 ('align date and datetime handling with spec'); maybe earlier as #291 before that had mentioned 'it's better to use local timezone than UTC'

CLI client defaults to server timezone unless you specify --use_client_time_zone=true, for example:

clickhouse client -h server.local -q "INSERT INTO a VALUES ('2025-02-07 00:00:00')"
TZ=CET clickhouse client -h server.local -q "INSERT INTO a VALUES ('2025-02-07 00:00:00')" --use_client_time_zone=true
clickhouse client -h server.local -q "SELECT * FROM a"

gets me only the second timestamp shifted into the CET timezone

Should the library match the CLI?

What is the specification mentioned in 0704ee8, maybe that would help explain the motivation?

Or is it issue #135 which resulted in PR #291?

[SpencerTorres]

I'm surprised it doesn't use UTC by default. I'm not sure the user from #291 is correct, I think respecting the server time makes sense, but UTC is also a good default. We also have a context function that lets you change the timezone:

clickhouse-go/context.go

Line 152 in cc7cc36

func WithUserLocation(location *time.Location) QueryOption {

We also have the server's timezone per connection:

clickhouse-go/lib/proto/handshake.go

Line 54 in 36e3cc1

Timezone *time.Location