Skip to content

Fix clickhouse proxy issue, add support for database as query string DSN #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025

Conversation

kokizzu
Copy link
Contributor

@kokizzu kokizzu commented Apr 16, 2025

Summary

some clickhouse proxy use database=bla as dsn not the path

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@kokizzu kokizzu changed the title Fix clickhouse proxy issue Fix clickhouse proxy issue, add support for database as query string DSN Apr 16, 2025
@jkaflik jkaflik requested a review from Copilot April 17, 2025 10:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kokizzu this change looks good. Thank you.

@kokizzu
Copy link
Contributor Author

kokizzu commented Apr 17, 2025

eh but makefile/CI breaks '__')
go mod tidy failed, i didn't change anything about go.mod

@jkaflik
Copy link
Contributor

jkaflik commented Apr 17, 2025

No worries - this is on our side with a broken main build. @SpencerTorres will address this.

@kokizzu
Copy link
Contributor Author

kokizzu commented Apr 18, 2025

yay green

Copy link
Member

@SpencerTorres SpencerTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like the query param's database takes priority over the path, which is reasonable logic

@SpencerTorres SpencerTorres merged commit b0d6afa into ClickHouse:main Apr 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants