Patch proposal for /var/lock/apache2 creation

[Raphux]

Hi,

Got a problem with apache ocf agent, on Debian (but I don't think it's distribution specific). After a fresh reboot, the agent couldn't start apache, with this in daemon.log :

ERROR: AH00526: Syntax error on line 74 of /etc/apache2/apache2.conf: Invalid Mutex directory in argument file:/var/lock/apache2

The directory /var/lock is a symbolic link to /run/lock, which is a tmpfs, that varnishes on reboot. So "/var/lock/apache2" must be created before launching apache2 tool.

For info, when launching Apache2 using apache2ctl, it creates the directory.

Here is a proposed patch :

--- apache.ori	2018-06-02 16:53:08.467570406 +0200
+++ apache	2018-06-02 17:04:56.212059045 +0200
@@ -204,6 +204,17 @@
 
 	validate_default_config || return $OCF_ERR_CONFIGURED
 
+	if [ ! -z "${APACHE_RUN_DIR}" ] && [ ! -d "${APACHE_RUN_DIR}" ]
+	then
+		mkdir -p "${APACHE_RUN_DIR}"
+	fi
+
+	if [ ! -z "${APACHE_LOCK_DIR}" ] && [ ! -d "${APACHE_LOCK_DIR}" ]
+	then
+		mkdir "${APACHE_LOCK_DIR}"
+		chown "${APACHE_RUN_USER}" "${APACHE_LOCK_DIR}"
+	fi
+
 	if [ -z $PIDFILE_DIRECTIVE ]; then
 		ocf_run $HTTPD $HTTPDOPTS $OPTIONS -f $CONFIGFILE
 	else

[oalbrigt]

Sounds like you might want to add it systemd-tmpfiles (which will create it on boot):
https://github.com/ClusterLabs/resource-agents/blob/master/systemd/resource-agents.conf

[Raphux]

Thank you for you answer, but I don't understand what you mean or what to do ?

Systemd-tmpfiles* services seem to be loaded :

root@host:~# systemctl list-units --all | grep tmpf
  systemd-tmpfiles-clean.service         loaded    inactive dead      Cleanup of Temporary Directories
  systemd-tmpfiles-setup-dev.service     loaded    active   exited    Create Static Device Nodes in /dev
  systemd-tmpfiles-setup.service         loaded    active   exited    Create Volatile Files and Directories
  systemd-tmpfiles-clean.timer           loaded    active   waiting   Daily Cleanup of Temporary Directories
root@host:~#

[oalbrigt]

It actually seems like your method is the optimal way to do this.