🧹 Refactor of the WorkspaceClient #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijseikelenboom
requested review from
austincondiff,
lukepistrol,
thecoolwinter,
Wouter01 and
KaiTheRedNinja
matthijseikelenboom
changed the title
matthijseikelenboom
changed the title
|
So, is this a complete replacement of the "old" |
|
@lukepistrol Oh yeah good catch, you're right |
matthijseikelenboom
force-pushed
the
refactor/workspace-client
branch
from
c940687 to
01e7f48
Compare
0xWDG
approved these changes
Mar 17, 2023
10 tasks
matthijseikelenboom
added a commit
to matthijseikelenboom/CodeEdit
that referenced
this pull request
Apr 28, 2023
austincondiff
pushed a commit
that referenced
this pull request
May 2, 2023
* 🧹 Refactor of the WorkspaceClient (#1157) * Transfer project navigator (#1208) * Transfer project navigator bottom * Transfer TableViewCell abstractions * Transfer over project manager outline view * Get proj navigator sidebar working again * Rename OutlineView -> ProjectNavigatorOutlineView for clarity * Remove debug statements * Fix incorrect comment headers * Change old AE assets to new CE assets * Add vscode-style toolbar * Disable vertical sidebar by default * Make deletion messages more descriptive * Fix table view cell alignments * Swiftlint fixes and code clean up * Test fixes --------- Co-authored-by: KaiTheRedNinja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the old
WorkspaceClientto a newCEWorkspaceFileManagerandWorkspaceItemtoCEWorkspaceFile.CEWorkspaceFileis no longer a inner class ofCEWorkspaceFileManager.NOTE: SwiftLint gives errors that the classes are too big, namely
CEWorkspaceFile. The thing is that we are building a complex application with sometimes big classes, so should we up the limit? I'm personally not a fan of extending of our own internal classes.NOTE 2: This PR will NOT be merged into main, because some functionality is broken. This will be fixed by @KaiTheRedNinja by implementing the AE navigation sidebar.
Related Issues
Checklist
Screenshots