Skip to content

Fix for issue: Property $beforeSpecify does not exist #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2016
Merged

Fix for issue: Property $beforeSpecify does not exist #37

merged 5 commits into from
Oct 21, 2016

Conversation

ischenko
Copy link
Contributor

@ischenko ischenko commented Oct 18, 2016 •
edited
Loading

Fixes issue described in #35

@ischenko ischenko mentioned this pull request Oct 18, 2016
Merged
@ischenko
Copy link
Contributor Author

@sergeyklay
I've added private properties of the class which uses Specify trait to the clone list. In this way Specify will work as it was originally designed to work with get_object_vars

Please verify. Thanks.

@sergeyklay
Copy link
Contributor

@DavertMik I'll merge this PR. But I wouldn't to rush with release. At least a week. This time need to deal what could be broken.

Thanks @ischenko

@sergeyklay sergeyklay merged commit 21b586f into Codeception:master Oct 21, 2016
@ischenko ischenko deleted the fix-unknown-property branch October 21, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischenko @sergeyklay