fullScreenShot silently disables $excludeElements

[stefanfisk]

When using fullscreenShot, $excludeElements is not used.

https://github.com/Codeception/VisualCeption/blob/master/module/VisualCeption.php#L382

Moving hideElementsForScreenshot()/resetHideElementsForScreenshot() to outside the fullscreenShot if/else seems to work.

Does anyone know if there's a reason for the current state, or should I just submit a PR?

[buresmi7]

Hi, I think it is mistake, so please send PR :)

[stefanfisk]

I also found additional bugs with regards to fullscreenShot that I personally need fixed (not scrolling to top before iterating downwards, not cropping properly, and maybe something else I can't remember right now), so expect a PR within the coming weeks!

[mgerasimchuk]

@buresmi7 hi,
I also faced this issue and prepared MR #66 to fix it.
Please see if you have time