Skip to content

🚧 Add check for VM to test for Longpath #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

michael-hawker
Copy link
Member

Doing a test to see if windows latest vm has long path enabled already, see actions/runner-images#1052

@michael-hawker
Copy link
Member Author

@Arlodotexe I'm more confused now, looks like long paths are already enabled... @jeromelaban any ideas on what's going on with the DirectoryNotFound long path for the Xamarin generator?

#211 (comment)

D:\a\Labs-Windows\Labs-Windows\labs\StackedNotificationsBehavior\samples\StackedNotificationsBehavior.Samples\obj\Release\xamarinios10\g\NativeCtorsGenerator\StackedNotificationsBehaviorExperiment_Samples_StackedNotificationsBehaviorCustomSample_3aca12002872ed9de2d15c6b3ebbd506.g.cs

@jeromelaban
Copy link
Collaborator

@Arlodotexe I'm more confused now, looks like long paths are already enabled... @jeromelaban any ideas on what's going on with the DirectoryNotFound long path for the Xamarin generator?

Yes, this is generally cause by the fact that Xamarin projects use Uno.SourceGenerationTasks because of their supported C# version (7.3, in general). Given VS 2022 is used, you can switch it to use Roslyn's embedded generation by adding this to the csproj files:

<PropertyGroup>
    <UnoUIUseRoslynSourceGenerators>true</UnoUIUseRoslynSourceGenerators>
</PropertyGroup>

Note that Directory.Build.props may not work as intended in the case of legacy projects, requiring to place this property in all xamarin project files.

@michael-hawker
Copy link
Member Author

@Arlodotexe I know you were tinkering with updating Uno to the latest version as well. Did you try this UnoUIUseRoslynSourceGenerators flag their as well?

<PropertyGroup>
    <UnoUIUseRoslynSourceGenerators>true</UnoUIUseRoslynSourceGenerators>
</PropertyGroup>

I know we had some concerns on overlapping source generators between Uno and Labs, eh?

@michael-hawker
Copy link
Member Author

Closing this as we now know the VMs already have long-path support enabled, so that's not the issue. Trying some things out in the #211 PR now.

michael-hawker added a commit to CommunityToolkit/Tooling-Windows-Submodule that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants