Skip to content

Filter incrementally changed component in CI by MultiTarget/WinUI support #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Arlodotexe
Copy link
Member

Refactored incremental builds and packaging in CI to filter and run only changed components that support the current WinUI/MultiTarget configuration.

Prerequisite tooling PR CommunityToolkit/Tooling-Windows-Submodule#288

Fixes an issue found in #680

…nly changed components that support the current WinUI/MultiTarget configuration.

Includes changes from CommunityToolkit/Tooling-Windows-Submodule#288
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the CI workflow to only build and package components that support the current WinUI/MultiTarget configuration.

  • Updates submodule pointer for tooling to latest commit
  • Adds filtering step to determine and gate on "buildable" components before generating, building, testing, and packing
  • Applies conditional if: HAS_BUILDABLE_COMPONENTS == 'true' checks to relevant workflow steps

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tooling Updated submodule commit to pick up new filtering scripts
.github/workflows/build.yml Added PowerShell filtering for changed components, and gated downstream steps on HAS_BUILDABLE_COMPONENTS
Comments suppressed due to low confidence (1)

.github/workflows/build.yml:139

  • [nitpick] Since this variable now only contains components that passed the filter, consider renaming CHANGED_COMPONENTS_LIST to something like BUILDABLE_COMPONENTS_LIST to more accurately reflect its contents.
echo "CHANGED_COMPONENTS_LIST=$buildableChangedComponents" >> $env:GITHUB_ENV

@Arlodotexe Arlodotexe added enhancement Improvement to an existing feature build 🔥 CI/pipeline 🔬 functional Alignment with specifications and requirements labels Jun 6, 2025
@Arlodotexe Arlodotexe changed the title Filter incrementally component changes in CI by MultiTarget/WinUI support Filter incrementally changed component in CI by MultiTarget/WinUI support Jun 6, 2025
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs submodule pointer update once dependent PR merged. Had some questions over there about how logic works, but outcome appears valid here.

@Arlodotexe Arlodotexe enabled auto-merge June 9, 2025 19:40
@Arlodotexe Arlodotexe merged commit 94ecb1c into main Jun 9, 2025
21 of 22 checks passed
@michael-hawker michael-hawker deleted the ci/build-and-package/incremental-components/filter-buildable branch June 9, 2025 21:48
@Arlodotexe Arlodotexe restored the ci/build-and-package/incremental-components/filter-buildable branch June 9, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 CI/pipeline 🔬 enhancement Improvement to an existing feature functional Alignment with specifications and requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants