-
Notifications
You must be signed in to change notification settings - Fork 70
Filter incrementally changed component in CI by MultiTarget/WinUI support #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter incrementally changed component in CI by MultiTarget/WinUI support #681
Conversation
…nly changed components that support the current WinUI/MultiTarget configuration. Includes changes from CommunityToolkit/Tooling-Windows-Submodule#288
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors the CI workflow to only build and package components that support the current WinUI/MultiTarget configuration.
- Updates submodule pointer for tooling to latest commit
- Adds filtering step to determine and gate on "buildable" components before generating, building, testing, and packing
- Applies conditional
if: HAS_BUILDABLE_COMPONENTS == 'true'
checks to relevant workflow steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tooling | Updated submodule commit to pick up new filtering scripts |
.github/workflows/build.yml | Added PowerShell filtering for changed components, and gated downstream steps on HAS_BUILDABLE_COMPONENTS |
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:139
- [nitpick] Since this variable now only contains components that passed the filter, consider renaming
CHANGED_COMPONENTS_LIST
to something likeBUILDABLE_COMPONENTS_LIST
to more accurately reflect its contents.
echo "CHANGED_COMPONENTS_LIST=$buildableChangedComponents" >> $env:GITHUB_ENV
…mponent testing with WinUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs submodule pointer update once dependent PR merged. Had some questions over there about how logic works, but outcome appears valid here.
Refactored incremental builds and packaging in CI to filter and run only changed components that support the current WinUI/MultiTarget configuration.
Prerequisite tooling PR CommunityToolkit/Tooling-Windows-Submodule#288
Fixes an issue found in #680