Moved repeated test project properties into shared props files #74
Conversation
There was a problem hiding this comment.
VS did hang for me trying to run the All solutions' tests at first. Running the experiment ones after worked fine though. But I did notice it was trying to build the WASM project head to run the tests, maybe a dependency we can simplify for the build? (Is anyone else's WASM head failing the first deploy?)
@Arlodotexe did it work for you locally without issue?
How about creating a solution filter for |
I get regular (several times a day) VS hangs with this solution :( |
This was on the experiment solution, not the all-up one. |
Where are you seeing this? The CI doesn't run the tests against the experiment solution. Or is this locally? If I go from a clean repo, it builds everything if you run the tests before building the solution first, but this is expected as that's how the "Debug" configuration is set up. If this is a valid scenario, we could add a solution filter or a separate configuration that only builds what's needed for testing. Preferences? |
|
@mrlacey I guess it's an artifact of the solution Debug config and VS and how it builds. It's not important. Just something I noticed. @Arlodotexe did you have any issues? If it's working fine for you too, then we can commit this PR. |
There was a problem hiding this comment.
The Labs.Uwp.Test.props file is only importing Labs.Uwp.Base.props, and the naming makes it easy to confuse with Labs.Tests.Uwp.props.
Since the file has no WinAppSDK equivalent, has potentially confusing naming, and is doing very little, maybe we should consider just importing the Labs.Uwp.Base.props file directly in the UWP test project, and doing away with Labs.Uwp.Test.props.
|
Tested the All solution and the CanvasLayout solution, worked on first try 👍 |
Made these changes :) |
| common\Labs.Uwp.Base.props = common\Labs.Uwp.Base.props | ||
| common\Labs.Uwp.props = common\Labs.Uwp.props | ||
| common\Labs.Wasm.props = common\Labs.Wasm.props | ||
| common\Labs.WinAppSdk.props = common\Labs.WinAppSdk.props | ||
| Windows.Toolkit.Common.props = Windows.Toolkit.Common.props | ||
| EndProjectSection | ||
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Props", "Props", "{DB021AE9-57A4-41BA-822F-2C76AF4A385B}" | ||
| ProjectSection(SolutionItems) = preProject | ||
| tests\Labs.Tests.props = tests\Labs.Tests.props | ||
| tests\Labs.Tests.Uwp.props = tests\Labs.Tests.Uwp.props | ||
| tests\Labs.Tests.WinAppSdk.props = tests\Labs.Tests.WinAppSdk.props | ||
| EndProjectSection | ||
| EndProject |
There was a problem hiding this comment.
Are these getting merged or is there a Props in Props folder? Should we just have them all be grouped together? We can adjust this later for #73 anyway too.
There was a problem hiding this comment.
They don't live in a specific "Props" directory, just trying to reflect the addition of these as solution items that was done for the other props files.
…sFiles Moved repeated test project properties into shared props files
This is tidying up what was added for #48