Fix Windows Media Element Controls #2680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the `Width` property to `Auto` and added a `MaxWidth` property referencing `MediaTransportControlsMaxWidth`. Removed the previous `Width` setting for improved layout flexibility.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Windows Media Element controls by updating the custom transport controls' style properties to improve layout flexibility.
- Replaces the fixed Width setter with a dynamically computed MaxWidth property.
- Sets the Width property to "Auto" to better adapt to content.
Comments suppressed due to low confidence (1)
src/CommunityToolkit.Maui.MediaElement/ResourceDictionary.windows.xaml:9
- [nitpick] Consider placing the MaxWidth and Width setters together in a logical grouping for readability and maintainability; verify that the order does not unintentionally affect layout behavior.
<Setter Property="MaxWidth" Value="{StaticResource MediaTransportControlsMaxWidth}" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update customTransportcontrols style properties
Changed the
Widthproperty toAutoand added aMaxWidthproperty referencingMediaTransportControlsMaxWidth.Removed the previous
Widthsetting for improved layout flexibility.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
This updates the xaml for Media Elements controls in windows to more closely align behavior when using small video dimension sizes. Unlike previous PR this does not update the sample app.