Fix Windows Snackbar Registration #2755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Windows snackbar registration logic by adjusting the check for the number of windows open during the application shutdown.
- Changed the condition from checking for 1 open window to checking for 0 open windows in the OnClosed method.
- Ensures that notifications are unregistered only when there are no open windows, preventing crashes during app shutdown.
Comments suppressed due to low confidence (1)
src/CommunityToolkit.Maui/Options.cs:90
- The condition has been correctly updated from a check against 1 to 0, which should ensure that snackbar notifications are unregistered only when no windows remain. Please verify that this logic aligns with the overall lifecycle management of window events during app shutdown.
else if (Application.Current.Windows.Count is 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes a bug where you open and close multiple secondary windows in a Windows environment and have snackbar registered. This prevents the crash that occurs otherwise. This changes the check for
Application.Current.Windows.Countfrom1to0inOnClosedmethod for builder Configuration lifecycle events.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
There was a previous attempt to fix this but it set window count to unregister at 1 and not zero. After verifying that when app exits it does call LifeCycle events for
OnClosedduring shutdown whenApplication.Currentis not null and windows count is zero I created this PR to address the issue.