Skip to content

Old StyleCop version #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
azchohfi opened this issue Mar 24, 2020 · 2 comments · Fixed by #3189 or #3199
Closed

Old StyleCop version #3187

azchohfi opened this issue Mar 24, 2020 · 2 comments · Fixed by #3189 or #3199
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 improvements ✨ in progress 🚧
Milestone
6.1

Comments

@azchohfi
Copy link
Contributor

Describe the bug

The toolkit is using StyleCop.Analysers 1.0.2, which is a 2017 version, ~3 year old. Many fixes are not incorporated into our analysis since we use this old version.
Issue happening here: #3128

Expected behavior

Latest stable version of StyleCop.
@azchohfi azchohfi added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 24, 2020
@ghost ghost added the needs triage 🔍 label Mar 24, 2020
@ghost
Copy link

ghost commented Mar 24, 2020

Hello azchohfi, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@azchohfi azchohfi mentioned this issue Mar 24, 2020
Merged
7 tasks
@ghost ghost added the In-PR 🚀 label Mar 24, 2020
@michael-hawker michael-hawker added this to the 6.1 milestone Mar 25, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Mar 25, 2020
@azchohfi
Copy link
Contributor Author

Reopening. Sample project and unit tests are not updated.

@azchohfi azchohfi reopened this Mar 26, 2020
@ghost ghost added in progress 🚧 and removed Completed 🔥 labels Mar 26, 2020
@azchohfi azchohfi mentioned this issue Mar 26, 2020
Merged
7 tasks
@ghost ghost added the In-PR 🚀 label Mar 26, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Mar 26, 2020
@michael-hawker michael-hawker mentioned this issue Apr 1, 2020
Closed
36 tasks
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 improvements ✨ in progress 🚧
Projects
None yet
Milestone
6.1
2 participants
@azchohfi @michael-hawker