Skip to content

Centralized StyleCop version in Directory.Build.props. #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

azchohfi
Copy link
Contributor

Fixes #3187

Also removed ruleset files in favor of .editorconfig.

PR Type

What kind of change does this PR introduce?

  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Multiple versions of StyleCop and unused ruleset.

What is the new behavior?

Single version of StyleCop and migrated away from ruleset files.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Mar 26, 2020

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost Mar 26, 2020
@azchohfi azchohfi requested a review from michael-hawker March 26, 2020 18:44
Removed ruleset files in favor of .editorconfig.
@azchohfi azchohfi merged commit 3a9b082 into master Mar 26, 2020
@azchohfi azchohfi deleted the styleCopUpdate2 branch March 26, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old StyleCop version
3 participants