Skip to content

[Docs] README Required Dependencies #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yoshiask opened this issue May 24, 2020 · 11 comments
Closed

[Docs] README Required Dependencies #3299

yoshiask opened this issue May 24, 2020 · 11 comments

Comments

@yoshiask
Copy link
Contributor

The README lists a bunch of dependencies required to build the WCT projects. It includes C++ v142, but does not mention that it also requires the "Desktop development with C++" workload.

@ghost ghost added the needs triage 🔍 label May 24, 2020
@ghost
Copy link

ghost commented May 24, 2020

Hello yoshiask, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost
Copy link
Contributor

@yoshiask We are working on redesigning and adding a few things in the file. Thanks for the highlight. Would you like to update this by creating a PR?

@yoshiask
Copy link
Contributor Author

Sure thing, @Kyaa-dost!

@michael-hawker
Copy link
Member

As I mentioned in the PR, the C++ workload shouldn't be required.

If someone else can test on a fresh machine, that'd be good, but I just setup a fresh machine with this configuration as well.

@michael-hawker michael-hawker added the help wanted Issues identified as good community contribution opportunities label May 28, 2020
@ghost ghost removed the help wanted Issues identified as good community contribution opportunities label May 28, 2020
@michael-hawker
Copy link
Member

@yoshiask you don't happen to have a screenshot of what VS showed you when you opened the project initially, eh?

@yoshiask
Copy link
Contributor Author

@michael-hawker No, I don't, it didn't occur to me to save that

@michael-hawker
Copy link
Member

No worries, I know when it prompted me it was only about the C++ v142 dependency, not the C++ workload as a whole. When I clicked on it, it just installed that single dependency for me.

I wonder if it's a difference between VS versions. What VS 2019 version are you on?

@yoshiask
Copy link
Contributor Author

I think I was on 16.6.0, but I've updated since then so I don't really know.

@michael-hawker
Copy link
Member

@yoshiask were you building in debug or release mode? (though I don't think that should make a difference)

@yoshiask
Copy link
Contributor Author

yoshiask commented Jun 1, 2020

I was building in Debug

@ghost ghost removed the In-PR 🚀 label Aug 18, 2020
@Kyaa-dost
Copy link
Contributor

Going to close this as #3300 answered the issue.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants