-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add C++ workload to the dependencies list #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds the "Desktop development with C++" workload to the required dependencies. This closes #3299.
Thanks yoshiask for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yoshiask, looks good 🚀
@yoshiask the full C++ workload should only be needed to build the Win32 project, not the main repo. Did you check the next step for the |
@michael-hawker I did check that, but for whatever reason Visual Studio refused the build the sample app until that workload was installed |
@yoshiask what errors did Visual Studio give you? As initially I didn't have that workload installed on my new machine (as I just went through this process myself again). I only needed to install that workload to build our Win32 project in the other repo. |
@michael-hawker VS didn't actually give me an error. When I tried to build the Sample App, it popped up the VS Installer dialog and prompted me to install the Desktop C++ workload. |
The sample app might it it, yes, due to the one C++ dependency we have (GazeInteractions). |
Lets not merge this since we are removing the C++ dependency all together with #3427 |
This adds the "Desktop development with C++" workload to the required dependencies.
Fixes #3299
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information