Skip to content

Add C++ workload to the dependencies list #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add C++ workload to the dependencies list #3300

wants to merge 1 commit into from

Conversation

yoshiask
Copy link
Contributor

This adds the "Desktop development with C++" workload to the required dependencies.

Fixes #3299

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

This adds the "Desktop development with C++" workload to the required dependencies. This closes #3299.
@ghost
Copy link

ghost commented May 26, 2020

Thanks yoshiask for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned azchohfi May 26, 2020
@ghost ghost added the documentation 📃 label May 26, 2020
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yoshiask, looks good 🚀

@michael-hawker
Copy link
Member

@yoshiask the full C++ workload should only be needed to build the Win32 project, not the main repo. Did you check the next step for the C++ (v142) Universal Windows Platform tools option under the UWP workload?

@yoshiask
Copy link
Contributor Author

@michael-hawker I did check that, but for whatever reason Visual Studio refused the build the sample app until that workload was installed

@michael-hawker
Copy link
Member

@yoshiask what errors did Visual Studio give you? As initially I didn't have that workload installed on my new machine (as I just went through this process myself again).

I only needed to install that workload to build our Win32 project in the other repo.

@yoshiask
Copy link
Contributor Author

@michael-hawker VS didn't actually give me an error. When I tried to build the Sample App, it popped up the VS Installer dialog and prompted me to install the Desktop C++ workload.

@azchohfi
Copy link
Contributor

The sample app might it it, yes, due to the one C++ dependency we have (GazeInteractions).

@azchohfi
Copy link
Contributor

Lets not merge this since we are removing the C++ dependency all together with #3427

@michael-hawker
Copy link
Member

Thanks @yoshiask, we've been discussing removing C++ from the Toolkit, so with @azchohfi's PR this becomes a moot point.

Going to close this out.

@yoshiask if you have any more pointers on getting started, let me know in Discord. We're going to be improving that guidance in the PR #3269 too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] README Required Dependencies
4 participants