-
Notifications
You must be signed in to change notification settings - Fork 1.4k
SampleApp rebuilds even if no changes #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was investigating this problem in another app and so thought I'd contribute the fix here too. The issue was that some |
…ed (#3558) <!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 --> ## Fixes #3332 <!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. --> <!-- Add a brief overview here of the feature/bug & fix. --> Stop the sample app from always triggering a rebuild, even if no code has been changed. ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more that apply to this PR. --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> - Other... Please describe: Change in compilation behavior of the Sample App ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> VS will always rebuild the sample app when launched for debugging. ## What is the new behavior? <!-- Describe how was this issue resolved or changed? --> Now VS will only rebuild the code if something has changed. ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tested code with current [supported SDKs](../readme.md#supported) - [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link --> - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets) - [ ] Tests for the changes have been added (for bug fixes / features) (if applicable) - [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [x] Contains **NO** breaking changes **All unchecked options above are not applicable** <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. --> ## Other information
Describe the bug
If you run the sample app with F5, and then later after closing it hit F5 again without making code changes, VS rebuilds the SampleApp project. ☹
Steps to Reproduce
Steps to reproduce the behavior:
Expected behavior
Sample App Launches 'immediately'
Actual behavior
VS rebuilds Sample App Project and then runs.
Environment
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: