ImageEx.CornerRadius property not working anymore #3528
Labels
Milestone
Comments
Sergio0694
added
bug 🐛
7 tasks
|
Nice catch, thanks @Sergio0694! Were there any other controls we were doing this on? (I'm guessing not, but could be good to check for new properties we've overridden). |
|
@Sergio0694 Did a solution-wise search and didn't find anything, so I think we should be good 😄 |
ghost
pushed a commit
that referenced
this issue
Oct 15, 2020
## Fixes #3528 <!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. --> <!-- Add a brief overview here of the feature/bug & fix. --> ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more that apply to this PR. --> - Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> The `ImageEx.CornerRadius` property isn't working anymore. ## What is the new behavior? <!-- Describe how was this issue resolved or changed? --> Modifying `ImageEx.CornerRadius` works correctly. ## Additional detail With #3440, we bumped the minimum SDK to 1809 (build 17763), which is the first one with the `CornerRadius` being available in the `Control` class. I suspect building the controls package with that minimum SDK caused an issue with `ImageEx` defining the `CornerRadius` property again (using `new`), so that the XAML `TemplateBinding` ended up failing to find the correct property to bind to. It might also be because setting the property in XAML ended up setting the value for the incorrect duplicate one, so that binding was never update. Regardless, with that minimum version available there's no reason to duplicate that property in the first place, we can just use the built-in one and bind to that. This PR removes that duplicate property, fixing the issue. > **NOTE:** this is _technically_ a breaking change as we're removing a public property, but users should effectively not really notice any difference, unless they were for some reason setting that very specific property through reflection, which is highly unlikely. Adding the tag for correctness, since this is still in fact a breaking change. Not likely to be noticed though 😄 ## PR Checklist Please check if your PR fulfills the following requirements: - [X] Tested code with current [supported SDKs](../readme.md#supported) - [ ] ~~Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->~~ - [ ] ~~Sample in sample app has been added / updated (for bug fixes / features)~~ - [ ] ~~Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)~~ - [X] Tests for the changes have been added (for bug fixes / features) (if applicable) - [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [ ] Contains **NO** breaking changes
ghost
locked as resolved and limited conversation to collaborators
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
The
ImageEx.CornerRadiusproperty is no longer working.Setting that doesn't change how the image is displayed - no matter its value the image is always just a square.
6.1.1Steps to Reproduce
Steps to reproduce the behavior:
masterImageExsample pageCornerRadiusvalue are still rendered as quaresExpected behavior
Modifying
CornerRadiusshould apply to the displayed image.Screenshots
Environment
The text was updated successfully, but these errors were encountered: