Skip to content

Fixes #3012 working around NuGet/Home#8388 #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Conversation

michael-hawker
Copy link
Member

Fixes #3012

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

Cannot build in VS 2019 without additional steps outside of VS

What is the new behavior?

Can now clone project in VS 2019 and build/run sample app without trouble

Other information

Tested with VS 2019 16.5 Preview 1

Tested with VS 2019 16.5 Preview 1
@ghost
Copy link

ghost commented Dec 23, 2019

Thanks for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@azchohfi azchohfi merged commit 7eb9c0b into master Dec 23, 2019
@azchohfi azchohfi deleted the mhawker/fix-vs2019-build branch December 23, 2019 23:42
@michael-hawker
Copy link
Member Author

Thanks @onovotny @azchohfi for the review! FYI @nkolev92 workaround you suggested seems to be working. Will keep you posted if we see any other behaviors as a side-effect. Thanks again!

@michael-hawker michael-hawker added this to the 6.1 milestone Apr 1, 2020
@michael-hawker michael-hawker mentioned this pull request Apr 1, 2020
36 tasks
@Kyaa-dost Kyaa-dost added bug 🐛 An unexpected issue that highlights incorrect behavior nuget 📦 labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥 nuget 📦
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to do an msbuild restore in order to be able to build the WindowsCommunityToolkit solution
4 participants