#3185 - Oddness with Theming and Selection in InfiniteCanvas Control #3194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#3185
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
The InfiniteCanvas control had issues with the highlighting of the 'Bold' toggle button in the toolbar once a TextBox had been added to the Canvas.
The reason for this issue is because the original developer in an attempt to set the TextBox's SelectionHighlight color, had directly changed the bound theme brush's color - affecting the whole application.
The code that performed this change didnt actually have the desired effect anyway because in UWP the TextSelection background color ignores the opacity setting and color alpha channel.
By removing this ineffective code, I avoided the corruption of the Theme brush's color
What is the new behavior?
The 'Bold' Toggle button now adheres to theming correctly
PR Checklist
Please check if your PR fulfills the following requirements:
Other information