Skip to content

Fixed Guard APIs CS8777 warnings #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sergio0694
Copy link
Member

Follow up for #3167.

This feature adds the [DoesNotReturnAttribute] to internal throw methods, including a local copy for the .NET Standard 2.0 target. This fixes the nullability warnings, which were causing the build to fail.

PR Type

What kind of change does this PR introduce?

  • Bugfix

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented May 20, 2020

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost May 20, 2020
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't repro the original issue on my 2004 VS 16.5.5, forgot to try on newer VS. but LGTM

@michael-hawker
Copy link
Member

@Sergio0694 I've noticed a lot of your PRs have a ton of merge tracking commits listed, it almost seems like your master may be out of sync or something with the main fork?

@Sergio0694
Copy link
Member Author

@michael-hawker I had actually merged from upstream/master into my master right before branching off to make this PR, I thought that would've gotten rid of those merge commits 😕

Looks like they're all still listed there instead, is there something I should do to fix that?
I mean, my master is in sync with the toolkit's master now 🤔

Sorry for the clutter!

@michael-hawker
Copy link
Member

@Sergio0694 I'm not sure outside of force-pushing the master from the toolkit over your master and rebasing/fixing branches?

@michael-hawker michael-hawker added this to the 6.1 milestone May 20, 2020
@michael-hawker michael-hawker merged commit 5487b55 into CommunityToolkit:master May 26, 2020
@Sergio0694
Copy link
Member Author

Hey @michael-hawker, sorry I missed this notification!
I'll try that force push, thanks for the suggestion! 😊

@Kyaa-dost Kyaa-dost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants