-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fixed Guard APIs CS8777 warnings #3296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Guard APIs CS8777 warnings #3296
Conversation
Changes from official master
Changes from master
Changes from master
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't repro the original issue on my 2004 VS 16.5.5, forgot to try on newer VS. but LGTM
@Sergio0694 I've noticed a lot of your PRs have a ton of merge tracking commits listed, it almost seems like your master may be out of sync or something with the main fork? |
@michael-hawker I had actually merged from Looks like they're all still listed there instead, is there something I should do to fix that? Sorry for the clutter! |
@Sergio0694 I'm not sure outside of force-pushing the master from the toolkit over your master and rebasing/fixing branches? |
Hey @michael-hawker, sorry I missed this notification! |
Follow up for #3167.
This feature adds the
[DoesNotReturnAttribute]
to internal throw methods, including a local copy for the .NET Standard 2.0 target. This fixes the nullability warnings, which were causing the build to fail.PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templatesOther information