-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Deprecate TabView, RadialGradientBrush, Singleton, FacebookService #3315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Hi @michael-hawker ! Regarding the feature parity of RadialGradienBrush, I think that this might not be possible to implement right now. The WinUI brush uses the CompositionRadialGradientBrush which does not expose this property (or anything comparable). Maybe somebody else knows more about this, but I don't think that the current implementation would be able to provide an I haven't looked at the MenuBar issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some changes to the FB obsolete message, as well as pointed out the obsolete message is missing from the FB sample json file.
If you fix/disagree with these comments, you can check in.
Microsoft.Toolkit.Uwp.Services/Services/Facebook/FacebookService.cs
Outdated
Show resolved
Hide resolved
I'll address Herrick's comments later tonight and then we can merge. Thanks! |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Hmm, wonder if the bot only triggers the merge after approvals and not after builds? FYI @Kyaa-dost @azchohfi |
Related #3203
Marking things that will be removed in 7.0. Both TabView and RadialGradientBrush have graduated 🎉🎉🎉. There's one element missing from the WinUI RadialGradientBrush, but we'll see if we can get it in their 2.5, it should be a simple add. (@chingucoding were you looking at microsoft/microsoft-ui-xaml#2385 or the MenuBar one or both?)
PR Type
What kind of change does this PR introduce?