Improved codegen in Guard APIs #3323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
|
@michael-hawker Managed to fix my local branches, so there are no merge commits this time! 😄 |
|
I'm ok merging this. There is no behavioral change. Its only performance. |
azchohfi
approved these changes
Jun 4, 2020
michael-hawker
approved these changes
Jun 4, 2020
|
Thanks @Sergio0694, @john-h-k, and @tannergooding for the discussion on this topic and the improvement to this new API! |
|
Hey @azchohfi and @michael-hawker - thank you for the super quick review and merge! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed improvement for #3131 and #3167
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The JIT compiler always assumes that forward branches are taken, unless it can see that the branch always throws. This doesn't happen in our throw methods, as we have a secondary
ThrowHelper.Throw...method that actually creates the exceptions to throw in the correct format.What is the new behavior?
To work around this, all the
Guardconditions have been inverted to guarantee that the forward branch considered taken is the one corresponding to the successful path for the check being done. This also improves code readability, as the conditions in eachGuardAPI are no longer inverted.PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates