Skip to content

fix some spelling #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2020
Merged

fix some spelling #3420

merged 3 commits into from
Aug 11, 2020

Conversation

HerrickSpencer
Copy link
Contributor

@SimonCropp, per @michael-hawker request, I've restored your branch, and added this PR for you to comment on. The commit is still attributed to you.

Thanks!

@ghost
Copy link

ghost commented Aug 11, 2020

Thanks HerrickSpencer for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost August 11, 2020 17:05
@net-foundation-cla
Copy link

net-foundation-cla bot commented Aug 11, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@net-foundation-cla
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ HerrickSpencer sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@HerrickSpencer
Copy link
Contributor Author

Link to old PR: #3409

azchohfi
azchohfi approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@azchohfi azchohfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should open another issue to try to automate this so we check it on our build system (an Analyzer, maybe?) Did you manually fix all these?

@HerrickSpencer
Copy link
Contributor Author

HerrickSpencer commented Aug 11, 2020 via email •
edited by ghost
Loading

@azchohfi azchohfi merged commit 5bf4265 into master Aug 11, 2020
@azchohfi azchohfi deleted the moreSpelling branch August 11, 2020 22:40
michael-hawker
michael-hawker reviewed Aug 12, 2020
View reviewed changes
Microsoft.Toolkit.Uwp.Notifications/Adaptive/BaseTextHelper.cs
@@ -8,12 +8,12 @@ namespace Microsoft.Toolkit.Uwp.Notifications
{
internal class BaseTextHelper
{
internal static Element_AdaptiveText CreateBaseElement(IBaseText curr)
internal static Element_AdaptiveText CreateBaseElement(IBaseText baseText)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment here that we could leave this as current still for consistency with the change made in BaseImageHelper.cs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-hawker I was going to make this change for you.... but it looks like PR was merged already. Tell me if you'd like this modified back to "current".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker left review comments

@azchohfi azchohfi azchohfi approved these changes

@Kyaa-dost Kyaa-dost Kyaa-dost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HerrickSpencer @azchohfi @michael-hawker @Kyaa-dost @SimonCropp