Skip to content

Fix Debug AnyCPU config for XamlIslands Package Unit Test #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Dec 8, 2020

Conversation

alvinashcraft
Copy link
Contributor

Fix Debug AnyCPU config for XamlIslands.Package unit test project so it builds for x86.

Fixes

Fixes #3599

Updated the Debug|AnyCPU config for UnitTests.XamlIslands.Package to build for x86. This is what it was doing for Release|AnyCPU.

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

Build fails for Debug|AnyCPU

What is the new behavior?

Build succeeds for Debug|AnyCPU

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [x ] Contains NO breaking changes

Other information

VS2019 rearranged a bunch of the other project configs in the solution file. Feel free to reject everything but the changes on lines 751-753.

Fix Debug AnyCPU config for XamlIslands.Package unit test project so it builds x86.
@ghost
Copy link

ghost commented Dec 4, 2020

Thanks alvinashcraft for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Dec 4, 2020
@michael-hawker michael-hawker changed the title windows-toolkit#3599 Fix Debug AnyCPU config for XamlIslands Package Unit Test Dec 4, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Dec 4, 2020
@ghost ghost added the in progress 🚧 label Dec 4, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 37 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
Copy link
Member

@msftbot merge if @azchohfi approves.

@ghost
Copy link

ghost commented Dec 4, 2020

Hello @michael-hawker!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @azchohfi

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@michael-hawker
Copy link
Member

@azchohfi I've noticed VS has been trying to remove some of the Native lines whenever we edit the config via VS vs. manually. Is this alright?

I just generally wish this whole system wasn't based on GUIDs... Why couldn't have these just all been in a comma list under the project path link itself...?

@azchohfi
Copy link
Contributor

azchohfi commented Dec 8, 2020

We don't have the native configurations anymore. That was for the old C++ Gaze project we had. If its removing it, its fine.

@ghost ghost merged commit 0fbe036 into CommunityToolkit:master Dec 8, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥 in progress 🚧
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnitTests.XamlIslands.Package build fails when AnyCPU configuration is selected
3 participants