Skip to content

Aleader/notifications net 5 and native #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andrewleader
Copy link
Contributor

Fixes

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Dec 22, 2020

Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from michael-hawker December 22, 2020 02:28
@andrewleader andrewleader merged commit 3920ebc into aleader/notifications-net-5 Dec 22, 2020
@ghost ghost requested a review from azchohfi December 22, 2020 02:28
@delete-merged-branch delete-merged-branch bot deleted the aleader/notifications-net-5-and-native branch December 22, 2020 02:28
@ghost ghost requested review from Kyaa-dost and Rosuavio December 22, 2020 02:28
andrewleader added a commit that referenced this pull request Jan 26, 2021
* Works with .NET 5

* Keep UWP min version at 10240

* Undo accidentally committed change

* Aleader/notifications net 5 and native (#3644)

* Making package works but throws at runtime

* I think it all works!

* Remove comment and update description

* Support for UWP 10240

Just using winmd version

* Interop working on all but UWP 15063 and lower

* Fix warnings

* Support activating when process is elevated

* Fix warnings

* Nuspec updates

Co-authored-by: Alexandre Zollinger Chohfi <[email protected]>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant