-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Snooze/dismiss support in toast button builders #3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andrewleader, Thanks for all the work and for submitting the PR.
For testing purposes, whenever I am trying to run the sample app it keeps breaking for me the moment I select the Toast sample app and constantly encountering the following error. Wondering if you are able to repro this as well?
Whoops, fixing! |
Alright fixed! |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msftbot merge if @Kyaa-dost approves. Think we're good @andrewleader, this will be in the next preview dropping once we close our our |
Hello @michael-hawker! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrewleader for the fix. We are looking good 🚀
@msftbot nevermind |
Hello @Kyaa-dost! Because you've told me to reset the custom auto-merge settings, I'll use the configured settings for this repository when I'm merging this pull request. |
Fixes #3614
The toast button builders we added in 7.0 so far didn't support snooze/dismiss activation, it makes sense to have a single way of constructing a button regardless of the activation type.
Additionally, this helps us converge on using
Uri
types for images rather thanstring
as mentioned in issue #3614.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Had to use a separate button type previously...
What is the new behavior?
Can use the same button builder, and the image consistently uses
Uri
type.PR Checklist
Please check if your PR fulfills the following requirements:
Other information