Skip to content

Move DispatcherQueueTimerExtensions to Microsoft.Toolkit.Uwp #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michael-hawker
Copy link
Member

Fixes #3706

Moves this class to where it should be next to our other DispatcherQueue Extensions. 🙂

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes)

What is the current behavior?

Was in the UI package.

What is the new behavior?

In the UWP package.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker added this to the 7.0 milestone Feb 1, 2021
@ghost ghost added the in progress 🚧 label Feb 1, 2021
@ghost
Copy link

ghost commented Feb 1, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working fine.

@ghost
Copy link

ghost commented Feb 4, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Feb 8, 2021
@michael-hawker michael-hawker merged commit 7039036 into CommunityToolkit:master Feb 9, 2021
@ghost ghost added Completed 🔥 and removed in progress 🚧 labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ Completed 🔥 extensions ⚡ introduce breaking changes 💥 maintenance ⚙️ next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cleanup] Move DispatcherQueueTimerExtensions to Microsoft.Toolkit.Uwp
2 participants