Fix ToastContentBuilder audio ms-winsoundevent and ms-appx #3755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3753
Add support for using ms-windsoundevent and ms-appx in the toast content audio builder (previously we were incorrectly throwing an exception when devs provided those). Also added unit tests to ensure this works correctly and ensure we correctly throw on https audio urls and other non-supported ones.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Throws when you try to use
ms-winsoundevent:
orms-appx:
, both of which are supported by Windows. Today it only supports absolute file paths (C:\audio.mp3
), which are only supported by desktop apps.What is the new behavior?
Doesn't throw for those.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information