Skip to content

Changed to Cake.GitVersioning and added 'nbgv cloud' on smoke test job. #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

azchohfi
Copy link
Contributor

Fixes #3775

This PR updates NBGV, as well as makes sure 'that nbgv cloud' is called on the Smoke Test step, which was failing the smoke tests sometimes.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

Sometimes the smoke test tries to restore the wrong version of the nugets.

What is the new behavior?

Now the same version should be properly used on both ADO jobs.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Feb 23, 2021

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, Kyaa-dost and Rosuavio February 23, 2021 01:15
@michael-hawker
Copy link
Member

@azchohfi think another pre-cursor step is missing:

'nbgv' is not recognized as an internal or external command,

@michael-hawker
Copy link
Member

@azchohfi same issue:

'nbgv' is not recognized as an internal or external command

Since this is a separate job in a new environment we need to install the tool again first, eh?

  - task: DotNetCoreCLI@2
    inputs:
      command: custom
      custom: tool
      arguments: install --tool-path . nbgv
    displayName: Install NBGV tool

@azchohfi
Copy link
Contributor Author

I'm stupid. I fixed it, rebased to keep a clean commit history and then, for god-knows-why, reverted the fix..... Pushing again, properly now.

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it worked this time now. Let's commit and see if it's stable over other PRs. Thanks!

@ghost
Copy link

ghost commented Feb 23, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
Copy link
Member

Looks like it's working as updated, so will merge. Thanks @azchohfi!

@michael-hawker michael-hawker merged commit 6ba1e44 into master Feb 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the versionFix branch February 23, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Build is failing in Smoke Tests intermittently due to NuGet version
2 participants