Skip to content

Update InAppNotification style to match WinUI InfoBar #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michael-hawker
Copy link
Member

Fixes #3770

Rebase of PR from #3771 to not submit from main branch of fork. Also adjusts DPI scaling height of buttons from 30 to 32.

Will just merge, as PR was signed-off already, this is just a rebase to avoid potential problems from submitting main to main.

FYI @ismaelestalayo - More info in Wiki

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Feb 23, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker michael-hawker added this to the 7.0 milestone Feb 23, 2021
@ghost ghost requested review from azchohfi, Kyaa-dost and Rosuavio February 23, 2021 20:22
@michael-hawker michael-hawker merged commit ed6b5b6 into CommunityToolkit:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update InAppNotification style
2 participants