Skip to content

Added removal for Storyboard completion handler #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sergio0694
Copy link
Member

Fixes https://twitter.com/thenickrandolph/status/1368356524582596609

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The Storyboard.BeginAsync is never removing the handler.

What is the new behavior?

The handler is removed when the event is raised.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added animations 🏮 extensions ⚡ optimization ☄ Performance or memory usage improvements labels Mar 7, 2021
@Sergio0694 Sergio0694 added this to the 7.0 milestone Mar 7, 2021
@ghost
Copy link

ghost commented Mar 7, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi, Kyaa-dost and Rosuavio March 7, 2021 23:11
@ghost ghost added the in progress 🚧 label Mar 7, 2021
@Sergio0694 Sergio0694 merged commit e5cb937 into CommunityToolkit:master Mar 8, 2021
@Sergio0694 Sergio0694 deleted the bugfix/storyboard-event-unsubscribe branch March 8, 2021 14:52
@ghost ghost added Completed 🔥 and removed in progress 🚧 labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants