Rangeselector refactor #3818
Closed
Rangeselector refactor #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an get the step values correctly CommunityToolkit#3476
…being created when we need them
Replace with FormatForToolTip
into file based on type of input
Clean-up some Style-cop issues.
These properties and their descriptions were confusing (and abbreviated) which made it difficult to understand how they differed from the Minimum/Maximum value properties. This clearly now separates which properties are being selected by the user. Their comments have been updated as well. It also aligns with the new Range struct field names in .NET: Start/End.
Think there's an issue with DataRow and the Cleanup Method though Also getting a 'Parameter count Mismatch' from MSTest before anything is even run :(
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
|
I have no idea what caused the tests to fail, it seems like they just stopped... @azchohfi any ideas on how we can debug what's going on here? Locally they seem to just stop at one point and spit out: |
|
Debugged one of the tests and hit a StackOverflow for RangeEnd in one of the tests that wasn't reporting. Wonder if that's messing things up elsewhere? |
|
Superseded by #3822 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #3812
Fixes
Rebased and merged in some more tests. Cleaned-up some style-cop issues and fixed some base test infrastructure issues. Tests should represent valid scenarios, but this code-base is emitting problems.
Also renamed properties for clarity.
Looks like RangeEnd is always set to 1 on initial construction.
FYI @RosarioPulella
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information