-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add description for Controls meta package #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description for Controls meta package #3829
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj
Outdated
Show resolved
Hide resolved
@RosarioPulella can you add the readme.txt here to the Controls package as well for #3782 (we should just include it as a loose file like we do the license of the other packages, just in the root). Also, can you make sure we have an explicit WinUI 2.5 reference on all the sub-packages? I think we only have it on a couple, and we should probably ensure that we will be consistent against that style. Thanks! |
…trols.csproj Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
@michael-hawker Should be all good now |
Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj
Outdated
Show resolved
Hide resolved
Thanks @RosarioPulella, once the build is finished, I'll validate it works as intended in VS! 🎉 |
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 6 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes #3814 #3782
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No description for Controls meta package.
What is the new behavior?
Description for Controls meta package.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information