Skip to content

Add description for Controls meta package #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 11, 2021
Merged

Add description for Controls meta package #3829

merged 8 commits into from
Mar 11, 2021

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Mar 10, 2021

Fixes #3814 #3782

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

No description for Controls meta package.

What is the new behavior?

Description for Controls meta package.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 10, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost March 10, 2021 21:14
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior nuget 📦 labels Mar 10, 2021
@michael-hawker
Copy link
Member

@RosarioPulella can you add the readme.txt here to the Controls package as well for #3782 (we should just include it as a loose file like we do the license of the other packages, just in the root).

Also, can you make sure we have an explicit WinUI 2.5 reference on all the sub-packages? I think we only have it on a couple, and we should probably ensure that we will be consistent against that style.

Thanks!

@Rosuavio Rosuavio requested a review from michael-hawker March 10, 2021 22:16
@Rosuavio
Copy link
Contributor Author

@michael-hawker Should be all good now

@michael-hawker michael-hawker linked an issue Mar 10, 2021 that may be closed by this pull request
@michael-hawker
Copy link
Member

Thanks @RosarioPulella, once the build is finished, I'll validate it works as intended in VS! 🎉

@michael-hawker
Copy link
Member

Installing the world...

image

Woot, it worked! Everything looks great. 🙂

image

It just doesn't word-wrap, so I'll make a suggestion commit that and we're good.

@michael-hawker michael-hawker added this to the 7.0 milestone Mar 11, 2021
@ghost
Copy link

ghost commented Mar 11, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 6 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior nuget 📦
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCT 7.0 Preview 5 NuGet package missing description Add readme to Controls package
3 participants