Skip to content

Using DispatcherQueue instead of CoreDispatcher #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Conversation

azchohfi
Copy link
Contributor

Fixes #3803

Some classes were still using CoreDispatcher.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Some classes are not working properly on Xaml Islands

What is the new behavior?

We don't use the old Dispatcher anymore. Everything is using DispatcherQueue and/or DispatcherQueueTimer.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Mar 10, 2021

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from Kyaa-dost March 10, 2021 22:28
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior improvements ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dispatcher/DispatcherTimer references to DispatcherQueue/DispatcherQueueTimer
2 participants