Skip to content

Fix error message display for InAppNotification used in Sample App #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jun 16, 2021

Conversation

michael-hawker
Copy link
Member

We missed updating a template somewhere, so fatal errors aren't displaying in the Sample App. Ideally this message never appears, this is being surfaced from our issues with ICommand in the ListView samples. #4039

PR Type

What kind of change does this PR introduce?

  • Sample app changes

What is the current behavior?

Error box appears blank.

What is the new behavior?

Error message shows exception message.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker added this to the 7.1 milestone Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi, Kyaa-dost and Rosuavio June 3, 2021 21:31
@ghost
Copy link

ghost commented Jun 15, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. I think its worth mentioning here we still can get errors in samples after they load and that cause the sample app to crash. #4063.

@ghost ghost merged commit e8029ec into CommunityToolkit:main Jun 16, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants