Handle theme changes in ColorPickerSlider

[robloo]

Fixes

Fixes #4714 (discussed in Issue)

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

See issue description.

What is the new behavior?

ColorPickerSlider thumb color changes in response to control theme changes.

PR Checklist

Please check if your PR fulfills the following requirements:

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• Tested code with current supported SDKs
• New component
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • If control, added to Visual Studio Design project
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

Other information

[ghost]

Thanks robloo for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[michael-hawker]

Hi @robloo thanks for opening another PR for this particular issue, somehow missed it so it wasn't on our tracking board.

I didn't see a noticeable difference in the behavior with this fix applied though? Either switching or when loaded, it seems difficult to see the checkerboard in light mode.

[robloo]

@michael-hawker This works fine and is doing what was intended. The original issue is the selector circle on the sliders weren't visible against the background color. That is fixed by calling UpdateColors when the theme changes to recalculate the foreground.

Microsoft is investing almost nothing in this repository and I don't see it worth my time to continue here. When you asked me to look into the last few issues for the ColorPicker I did immediately -- over the weekend. You then let them sit for a few months. I can't accept my time being used like that.

Edit: I've closed the PR (which does still work) because I don't intend to spend more time here. However, you are welcome to resurrect it or use the ideas in a new PR to fix the associated issue.

[michael-hawker]

@robloo I'm sorry you feel like that, and I apologize. As I called out, I had missed seeing this PR and adding it to our dashboard we've been using to track the upcoming hotfix. I just misunderstood what this fix was about and what to be looking for. We're still investing in the toolkit, as you can see the upcoming hotfix will have nearly 50 fixes: Windows Community Toolkit (view)

We're at a transitional period with the introduction of the Windows App SDK, and we've been figuring out how we best support our community moving forward for the long-term with the Toolkit. That's why we spent time to figure out how to rebuild our infrastructure with our new Windows Community Toolkit Labs (see #4487). It allows us to write and test code easily across both UWP and the Windows App SDK (which we can't do here yet), so the next phase is to adopt that system in this repo. These things just take time and we're a small team. We value and appreciate the contributions of our community members, like yourself. I'd love to still merge this PR of yours.