Skip to content

updates to support installing automactc script via pip #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryandeivert
Copy link

@ryandeivert ryandeivert commented Apr 27, 2019

to @kshitijkumar14

We are interested in leveraging some of the functionality of automactc, but cannot do so in its current form. Ideally, this would be installable via pip to support on-demand installation (when applicable). These changes are largely to support that.

I'm happy to answer any questions about the change or update as you see fit. With these changes, you will be able to publish to pypi.

Changes

  • Implementing modules as classes to remove executing of modules at import time.
    • This resulted in a significant amount of line changes, but the majority of the code itself has been unchanged.
  • Introducing ModuleRegistry for storing and accessing module classes.
  • Refactoring the CLI to reduce the use of globals and removing usage of __main__ imports from modules.
    • The API for the CLI remains unchanged - all arguments are the same, and the code is largely the same. I've introduced a CLIRunner class to help organize things and store variables.
  • Migrating python package files to within a top-level automactc folder to better support packaging.
  • Adding setuptools support (setup.py) to allow for installing via pip. This will result in a automactc executable being installed.
    • I have added placeholder info to the setup.py for now - this can be updated as desired prior to publishing to pypi.

@ryandeivert
Copy link
Author

@kshitijkumar14 any chance I could get some feedback on this?

@kshitijkumar14
Copy link
Contributor

Hi @ryandeivert - thanks a ton for these updates. I'll be reviewing these and will follow up with you.

@ryandeivert
Copy link
Author

thanks @kshitijkumar14 :) friendly ping again to keep this alive. any updates?

@ryandeivert
Copy link
Author

hello @kshitijkumar14 .. just curious if this is still on your radar. I think a lot of people would benefit from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants