Skip to content

Apply templates patches in Git repo with --commit-patches option #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jirikuncar
Copy link
Contributor

@jirikuncar jirikuncar commented Feb 2, 2021

What does this PR do?

Applies commit patches in Git repository for easier modification of patches.

Description of the Change

Adds option --commit-patches to apigentools templates command.

Alternate Designs

Possible Drawbacks

The template patches do not contain path prefix based on openapi-generator. It can be considered advantage as we had witnessed change of template folder from go-experimental to go.

Verification Process

Additional Notes

Update template patches:

$ cd templates/<lang>/<version>
$ git log --pretty=format:"%H:%s" --reverse | tail -n +2 | while IFS=: read -r commit file; do git diff $commit^..$commit > ../../../$file; done

Get list of template patches for a language:

$ cd templates/<lang>/<version>
$ git log --pretty=format:"- %s" --reverse | tail -n +2

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@jirikuncar jirikuncar requested a review from a team as a code owner February 2, 2021 09:53
@github-actions
Copy link

github-actions bot commented Apr 5, 2021

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale - Bot reminder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant