Skip to content

Setup Code Scanning on datadog-api-client-python #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ganeshkumarsv
Copy link
Contributor

Static code analysis on datadog-api-client-python using Github's Code Scanning.

This PR has Github workflow configs to trigger the Code Scanning on every PR and on push to master branch. As of now only default security based CodeQL queries are configured. We can gradually add queries for Code Quality later.

@ganeshkumarsv ganeshkumarsv requested a review from a team as a code owner July 13, 2022 09:36
@therve
Copy link
Contributor

therve commented Jul 13, 2022

This is pretty slow, do we have to run it on every PR? Is there a way to make it faster?

@ganeshkumarsv
Copy link
Contributor Author

@therve If it slows down the pipeline, we can make it to run on every push to default branch. But running on PR helps to find the issues before they get merged to default branch. It is a part of Datadog compliance requirements to regularly perform code-scanning on all the customer installed code.

@therve
Copy link
Contributor

therve commented Jul 13, 2022

@therve If it slows down the pipeline, we can make it to run on every push to default branch. But running on PR helps to find the issues before they get merged to default branch. It is a part of Datadog compliance requirements to regularly perform code-scanning on all the customer installed code.

Right if you don't mind, I'd reduce it master push. This should fill the requirements while not having bad effect on the pipeline.

@ganeshkumarsv
Copy link
Contributor Author

I've removed scanning on every PR. Please let me know if the PR looks good 🙇

@therve therve merged commit 0c5205f into master Jul 13, 2022
@therve therve deleted the CONTSEC-496-setup-code-scanning-on-datadog-api-client-python branch July 13, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants