Add support for retry of HTTP requests #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
therve
requested changes
Jul 24, 2023
github-actions
bot
added
the
documentation
therve
approved these changes
Jul 25, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
* add retry and its configs * auto reformat * format * redo is_retry and rewrite retry config options * Reformat * Fix syntax & add test * Fixe test & adjusting retry impl * pre-commit fixes * Update template * Fix import * pre-commit fixes * change retry import * remove retry import * remove saving content of the response * update cassette * delete env file * update cassette * use mock for test_retry * pre-commit fixes * use urllib3 for requests * pre-commit fixes * fix return format * pre-commit fixes * add response header * pre-commit fixes * change retry test * pre-commit fixes * update test_retry * pre-commit fixes * use call count * pre-commit fixes * Update .generator/src/generator/templates/rest.j2 Co-authored-by: Thomas Hervé <[email protected]> * pre-commit fixes * Add back test * pre-commit fixes * Fix content encoding * touch up rest client and test * pre-commit fixes * add test without reset header * pre-commit fixes * change allowed method check * Minor tweaks * Use cassette for errors as well * Docs --------- Co-authored-by: ci.datadog-api-spec <[email protected]> Co-authored-by: Thomas Hervé <[email protected]> afd63b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding retry and configuration options to the client
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.