Pass SSL configuration arguments to Async Api Client #1655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration arguments aren't correctly passed into the async rest client. This can result in ssl errors even after we've disabled ssl verification in the configuration. ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)
Fix AsyncRestClient Missing SSL Params
|
Hi, Thanks for the patch! Do you mind changing the source at |
|
Added |
therve
changed the title
therve
approved these changes
Sep 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Fix AsyncRestClient Missing SSL Params Configuration arguments aren't correctly passed into the async rest client. This can result in ssl errors even after we've disabled ssl verification in the configuration. ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1002) * Update rest.j2 e54f10b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL Configuration Arguments Not Passed to Async Api Client
The current datadog api client fails to pass ssl_verify argument to the AsyncApiClient which will result in
self._sslobj.do_handshake() ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)Linked Issue: #1654