Skip to content

Pass all keyword/ arguments to avoid panics with setuptools_scm > 8 #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

Pass all keyword/ arguments to avoid panics with setuptools_scm > 8 #1702

merged 2 commits into from
Oct 3, 2023

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Oct 3, 2023

Avoid panics such as:

TypeError: parse_fetch_on_shallow() got an unexpected keyword argument 'config'

@skarimo skarimo requested a review from a team as a code owner October 3, 2023 13:53
@skarimo skarimo merged commit d837d72 into master Oct 3, 2023
@skarimo skarimo deleted the sherz/setuptools-scm branch October 3, 2023 14:21
github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@skarimo
Pass all keyword/ arguments to avoid panics with setuptools_scm > 8 (…
ad8d0cd 
…#1702)

* use arg and kwargs

* unpin setuptools scm d837d72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkzou nkzou nkzou approved these changes

Assignees
No one assigned
Labels
changelog/Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skarimo @nkzou