Skip to content

Prioritize auth configuration values over environment variables #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

therve
Copy link
Contributor

@therve therve commented Dec 5, 2023

Setting DD_API_KEY and DD_APP_KEY in the environment should not override values manually passed to the configuration init.

Closes #1786

@therve therve requested a review from a team as a code owner December 5, 2023 13:16
Setting `DD_API_KEY` and `DD_APP_KEY` in the environment should not override values
manually passed to the configuration init.

Closes #1786
@therve therve force-pushed the therve/fix-keyloading branch from bf1fe97 to a17b2d6 Compare December 5, 2023 13:17
Copy link

github-actions bot commented Jan 5, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale label Jan 5, 2024
@therve therve merged commit c84ad6d into master Jan 5, 2024
@therve therve deleted the therve/fix-keyloading branch January 5, 2024 07:42
github-actions bot pushed a commit that referenced this pull request Jan 5, 2024
Setting `DD_API_KEY` and `DD_APP_KEY` in the environment should not override values
manually passed to the configuration init.

Closes #1786 c84ad6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters specified in the Configuration should take priority over envvars
2 participants