Enable additionalProperties by default #2111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
force-pushed
the
sherz/enable-additional-properties
branch
from
e078bd2 to
b863e84
Compare
jack-edmonds-dd
approved these changes
Aug 15, 2024
skarimo
force-pushed
the
sherz/enable-additional-properties
branch
from
3c2f782 to
b1d07df
Compare
jack-edmonds-dd
approved these changes
Aug 15, 2024
Co-authored-by: jack-edmonds-dd <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
* enable additionalProperties by default * enabled additionalProps * reduce change size * Update .generator/src/generator/templates/model_generic.j2 Co-authored-by: jack-edmonds-dd <[email protected]> * remove check --------- Co-authored-by: jack-edmonds-dd <[email protected]> 28d5556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is some conflicting behavior across multiple code paths. Some code path assumes additionalProperties is false by default where others, it is enabled. For example see:
https://github.com/DataDog/datadog-api-client-python/blob/master/.generator/src/generator/templates/model_utils.j2#L132
and
https://github.com/DataDog/datadog-api-client-python/blob/master/.generator/src/generator/templates/model_utils.j2#L400
To make sure behavior is uniform, lets enabled additionalProperties by default.