Create types for app builder queries explicitly, remove experimental flag #2411
Conversation
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
requested review from
a team
as code owners
| "outputs": "outputs", | ||
| } | ||
|
|
||
| def __init__(self_, outputs: Union[str, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
| def __init__(self_, outputs: Union[str, UnsetType] = unset, **kwargs): | |
| def __init__(self, outputs: Union[str, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "type": "type", | ||
| } | ||
|
|
||
| def __init__(self_, id: UUID, name: str, properties: StateVariableProperties, type: StateVariableType, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
| def __init__(self_, id: UUID, name: str, properties: StateVariableProperties, type: StateVariableType, **kwargs): | |
| def __init__(self, id: UUID, name: str, properties: StateVariableProperties, type: StateVariableType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "default_value": "defaultValue", | ||
| } | ||
|
|
||
| def __init__(self_, default_value: Union[Any, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
| def __init__(self_, default_value: Union[Any, UnsetType] = unset, **kwargs): | |
| def __init__(self, default_value: Union[Any, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "type": "type", | ||
| } | ||
|
|
||
| def __init__(self_, id: UUID, name: str, properties: DataTransformProperties, type: DataTransformType, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
| def __init__(self_, id: UUID, name: str, properties: DataTransformProperties, type: DataTransformType, **kwargs): | |
| def __init__(self, id: UUID, name: str, properties: DataTransformProperties, type: DataTransformType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
|
|
||
|
|
||
| class ActionQuerySpecInputsOneOf(ModelNormal): | ||
| def __init__(self_, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
| def __init__(self_, **kwargs): | |
| def __init__(self, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3543
branch
from
4270aeb to
4ce84c3
Compare
|
|
||
|
|
||
| class ActionQuerySpecInput(ModelNormal): | ||
| def __init__(self_, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
| def __init__(self_, **kwargs): | |
| def __init__(self, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3543
branch
4 times, most recently
from
4368a83 to
03fe898
Compare
…uilder-queries-explicitly
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3543
branch
from
03fe898 to
ab8d5e7
Compare
| "tags": "tags", | ||
| } | ||
|
|
||
| def __init__(self_, id: Union[UUID, UnsetType] = unset, tags: Union[List[str], UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
| def __init__(self_, id: Union[UUID, UnsetType] = unset, tags: Union[List[str], UnsetType] = unset, **kwargs): | |
| def __init__(self, id: Union[UUID, UnsetType] = unset, tags: Union[List[str], UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
…uilder-queries-explicitly
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3543
branch
4 times, most recently
from
edc9075 to
73ca7d5
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3543
branch
from
73ca7d5 to
480701d
Compare
ashley
changed the title
api-clients-generation-pipeline
bot
changed the title
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/3543
branch
…flag (#2411) * handle additionalProperties example * Regenerate client from commit 35df584d of spec repo --------- Co-authored-by: Sherzod Karimov <[email protected]> Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com> Co-authored-by: ci.datadog-api-spec <[email protected]> a959f3f
See DataDog/datadog-api-spec#3543
Test branch datadog-api-spec/test/oliver/create-types-for-app-builder-queries-explicitly