-
Notifications
You must be signed in to change notification settings - Fork 48
Introduce public v2 endpoints for Application Security #2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce public v2 endpoints for Application Security #2427
Conversation
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: ApplicationSecurityWafExclusionFilterUpdateData, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: ApplicationSecurityWafExclusionFilterUpdateData, **kwargs): | |
def __init__(self, data: ApplicationSecurityWafExclusionFilterUpdateData, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"status_code": "status_code", | ||
} | ||
|
||
def __init__(self_, location: Union[str, UnsetType] = unset, status_code: Union[int, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, location: Union[str, UnsetType] = unset, status_code: Union[int, UnsetType] = unset, **kwargs): | |
def __init__(self, location: Union[str, UnsetType] = unset, status_code: Union[int, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"service": "service", | ||
} | ||
|
||
def __init__(self_, env: str, service: str, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, env: str, service: str, **kwargs): | |
def __init__(self, env: str, service: str, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: Union[List[ApplicationSecurityWafCustomRuleData], UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: Union[List[ApplicationSecurityWafCustomRuleData], UnsetType] = unset, **kwargs): | |
def __init__(self, data: Union[List[ApplicationSecurityWafCustomRuleData], UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
supported languages) AWS Fargate. | ||
""" | ||
|
||
def __init__(self, api_client=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
function exceeds 200 lines (...read more)
This rule stipulates that functions in Python should not exceed 200 lines of code. The primary reason for this rule is to promote readability and maintainability of the code. When functions are concise and focused, they are easier to understand, test, and debug.
Long functions often indicate that a single function is doing too much. Adhering to the Single Responsibility Principle (SRP) can help avoid this. SRP states that a function should have only one reason to change. If a function is doing more than one thing, it can usually be split into several smaller, more specific functions.
In practice, to adhere to this rule, you can often break up long functions into smaller helper functions. If a piece of code within a function is independent and can be isolated, it is a good candidate to be moved into a separate function. This also increases code reusability. For instance, if a function process_data()
is too long, you can identify independent tasks within it - such as clean_data()
, transform_data()
, and save_data()
- and create separate functions for them. This makes the code easier to reason about and test, and promotes good coding practices.
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: Union[ApplicationSecurityWafExclusionFilterResource, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: Union[ApplicationSecurityWafExclusionFilterResource, UnsetType] = unset, **kwargs): | |
def __init__(self, data: Union[ApplicationSecurityWafExclusionFilterResource, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
94d7230
to
ff6e6d3
Compare
ff6e6d3
to
d6796a3
Compare
b47f5d9
to
c1a21ee
Compare
c1a21ee
to
b89fe0d
Compare
Co-authored-by: ci.datadog-api-spec <[email protected]> 1239b21
See DataDog/datadog-api-spec#3602
Test branch datadog-api-spec/test/nicolas.vivet/appsec